Skip to content

Conversation

@Fokko
Copy link
Contributor

@Fokko Fokko commented Sep 2, 2025

And some general cleanup.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

And some general cleanup.
@ArnavBalyan
Copy link
Member

LGTM! It seems there are some JIRA references in code https://github.com/apache/parquet-java/blob/master/parquet-column/src/main/java/org/apache/parquet/filter2/predicate/SchemaCompatibilityValidator.java#L57. Should they also point to Github now?

@ArnavBalyan
Copy link
Member

LGTM! It seems there are some JIRA references in code https://github.com/apache/parquet-java/blob/master/parquet-column/src/main/java/org/apache/parquet/filter2/predicate/SchemaCompatibilityValidator.java#L57. Should they also point to Github now?

Maybe should be okay as JIRA has the corresponding GH link in the comment

@wgtmac
Copy link
Member

wgtmac commented Sep 3, 2025

@ArnavBalyan Yes, I think linking to old JIRA issues is fine. They are the history. New issues should go with Github issue but not JIRA.

@wgtmac wgtmac merged commit 62a29b8 into master Sep 4, 2025
14 checks passed
rahulketch pushed a commit to rahulketch/parquet-java that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants